Conversation
Member
|
@christopherkenny hi! If you want this PR to close that issue you should change "addresses" to "closes" (or another keyword). But only if you do! Thanks for the PR! ❤️ |
Member
|
Great -- I went ahead and made the attribution myself. Will try it out. |
Contributor
Author
|
Thanks @pdurbin. Appreciate the tip. And thanks, Shiro. |
Contributor
Author
|
@kuriwaki, it looks like this is trying to run on a retired version of ubuntu for GHA. I believe the following should replace dataverse-client-r/.github/workflows/R-CMD-check-thorough.yaml Lines 28 to 29 in badfb70 |
Member
|
Thanks Chris. Looks good. The pipe version is helpful. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please ensure the following before submitting a PR:
/Rnot/manand rundevtools::document()to update documentation/testsfor any new functionality or bug fixR CMD checkruns without error before submitting the PRNote: I have not edited the tests, as there are no new features, just internal changes, but the existing tests pass.
addresses #142